Slicer4

BUG: #4323 add close button to DICOM widgets Without the hint, there was no way to close these windows on certain OS/window managers (e.g. ubuntu 14.04, 16.04). From: Steve Pieper

BUG: Fixed crash during application exit in SubjectHierarchy PluginHandler On application exit, qSlicerSubjectHierarchyPluginHandler is deleted before subject hierarchy node is deleted. Deletion of the node caused the callback command to execute and ... [More] call qSlicerSubjectHierarchyPluginHandler::onSubjectHierarchyNodeEvent, which referred to the deleted pluginHandler. Solution was to remove observers in the pluginHandler destructor. [Less]

BUG: Fixed FreeSurfer overlay colormap table Color names were overridden with default generated names (R=..., G=..., B=...). Changed the color table name to match the overlay file it is read from. Made overlay reading options in Add data dialog a bit more clear: added a "Apply to model:" label to the model node selector.

BUG: Fixed infinite loop in qMRMLModelDisplayNodeWidget::updateWidgetFromMRML

STYLE: Fix typo in License.txt Likely a Word character set issue. Reviewed-by: Steve Pieper

ENH: Add support for reading launcher setting using CTKAppLauncherLib This commit introduces a dependency to the statically linked library CTKAppLauncherLib This library also used internally by the regular Slicer launcher allows to read the ... [More] launcher main settings and its associated revision specific settings listing extensions paths. Since on all platforms, environment variables are now consistently read from settings files, this commit removes: (1) the duplicated code path settings variables from the application using methods like: * qSlicerCoreApplicationPrivate::setPythonEnvironmentVariables() * qSlicerCoreApplicationPrivate::setTclEnvironmentVariables() * qSlicerCoreApplicationPrivate::discoverITKFactoriesDirectory() * qSlicerCorePythonManager::pythonPaths() (2) the application settings "Python/AdditionalPythonPaths" originally introduced in r20852 (BUG: Ensure extension python paths are set on MacOSX) to workaround the fact launcher settings were not used on MacOSX. Finally, this commit also ensures that PYTHONPATH associated with thirdparty libraries bundled in extension are considered on MacOSX. See Radiomics/SlicerRadiomics#18 [ci skip] [Less]

ENH: SlicerCoreApplication: Introduces "isUsingLauncher()" function

STYLE: SlicerCoreApplication: Simplify code removing updatePythonOsEnviron() This commit simplifies the code removing optimization (use of "updatePythonOsEnviron()" function and associated cache variable "EnvironmentVariablesCache") initially ... [More] introduced in commits: * r16909 (BUG: Call updatePythonOsEnviron() after python is initialized.) * r18762 (ENH: Initialization of python context done within qSlicerCoreApplication) * r17611 (ENH: qSlicerCoreApplication - Add convenient function allowing to update environment). [Less]

STYLE: vtkITKArchetypeImageSeriesReader: Fix -Wsign-compare warnings /path/to/Projects/Slicer/Libs/vtkITK/vtkITKArchetypeImageSeriesReader.cxx: In member function ‘void ... [More] vtkITKArchetypeImageSeriesReader::SetMetaDataScalarRangeToPointDataInfo(vtkImageData*)’: /path/to/Projects/Slicer/Libs/vtkITK/vtkITKArchetypeImageSeriesReader.cxx:903:25: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] if (nbrOfComponents != this->MetaDataScalarRangeMinima.size() || ^ /path/to/Projects/Slicer/Libs/vtkITK/vtkITKArchetypeImageSeriesReader.cxx:904:25: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] nbrOfComponents != this->MetaDataScalarRangeMaxima.size()) ^ /path/to/Projects/Slicer/Libs/vtkITK/vtkITKArchetypeImageSeriesReader.cxx:923:32: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (unsigned int i = 0; i < nbrOfComponents; ++i) ^ [Less]

STYLE: vtkPolyDataToFractionalLabelmapFilter: Fix -Woverloaded-virtual warning In file included from /path/to/Projects/Slicer-Release/VTKv7/Common/Core/vtkVariant.h:37:0, from ... [More] /path/to/Projects/Slicer-Release/Slicer-build/Libs/vtkSegmentationCore/vtkPolyDataToFractionalLabelmapFilterPython.cxx:10: /path/to/Projects/Slicer-Release/VTKv7/Common/Core/vtkSetGet.h:312:14: warning: ‘virtual void vtkImageStencilSource::GetOutputOrigin(double&, double&, double&)’ was hidden [-Woverloaded-virtual] virtual void Get##name (type &_arg1, type &_arg2, type &_arg3) \ ^ /path/to/Projects/Slicer-Release/VTKv7/Imaging/Core/vtkImageStencilSource.h:71:3: note: in expansion of macro ‘vtkGetVector3Macro’ vtkGetVector3Macro(OutputOrigin, double); ^ In file included from /path/to/Projects/Slicer-Release/Slicer-build/Libs/vtkSegmentationCore/vtkPolyDataToFractionalLabelmapFilterPython.cxx:11:0: /path/to/Projects/Slicer/Libs/vtkSegmentationCore/vtkPolyDataToFractionalLabelmapFilter.h:89:8: warning: by ‘vtkPolyDataToFractionalLabelmapFilter::GetOutputOrigin’ [-Woverloaded-virtual] void GetOutputOrigin(double origin[3]); ^ In file included from /path/to/Projects/Slicer-Release/VTKv7/Common/Core/vtkVariant.h:37:0, from /path/to/Projects/Slicer-Release/Slicer-build/Libs/vtkSegmentationCore/vtkPolyDataToFractionalLabelmapFilterPython.cxx:10: /path/to/Projects/Slicer-Release/VTKv7/Common/Core/vtkSetGet.h:312:14: warning: ‘virtual void vtkImageStencilSource::GetOutputSpacing(double&, double&, double&)’ was hidden [-Woverloaded-virtual] virtual void Get##name (type &_arg1, type &_arg2, type &_arg3) \ ^ /path/to/Projects/Slicer-Release/VTKv7/Imaging/Core/vtkImageStencilSource.h:81:3: note: in expansion of macro ‘vtkGetVector3Macro’ vtkGetVector3Macro(OutputSpacing, double); ^ In file included from /path/to/Projects/Slicer-Release/Slicer-build/Libs/vtkSegmentationCore/vtkPolyDataToFractionalLabelmapFilterPython.cxx:11:0: /path/to/Projects/Slicer/Libs/vtkSegmentationCore/vtkPolyDataToFractionalLabelmapFilter.h:95:8: warning: by ‘vtkPolyDataToFractionalLabelmapFilter::GetOutputSpacing’ [-Woverloaded-virtual] void GetOutputSpacing(double spacing[3]); ^ [Less]