Slicer4

COMP: Fixed build warnings

ENH: Segmentation master representation is not changed during import When a model or lablemap node was imported into segmentation node and the master representation did not match the type of the imported node, the master representation of the ... [More] segmentation was changed. This behavior was not desirable, because it forced temporarily switching representation of all the nodes in the existing segmentation to something else, resulting in some potential loss of details. Changed behavior so that the imported node representation is changed during import (existing segments in the segmentation node are not changed in any way). [Less]

ENH: Added 'Crop to reference image geometry' segmentation conversion option If 'Crop to reference image geometry' is enabled, then when closed surfaces are converted to labelmaps, the extent of the generated labelmap will be restriced to the ... [More] reference image extent. It is useful for importing large models that have irrelevant parts outside the reference image. [Less]

BUG: Fixed crosshair centered jump mode When user translated a slice view, SliceOrigin was shifted and the crosshair did not appear in the center of the viewer. When centering the viewer, SlicerOrigin has to be reset to (0,0,0).

ENH: Simplified subject hierarchy node resolving process Subject hierarchy node resolving happens when a second subject hierarchy node appears in the scene - usually when a scene is imported. Then merging of the new SH nodes into the first one ... [More] happens, after which the new (and now empty) SH nodes are removed. It has been possible to observe items added when resolving using SubjectHierarchyItemResolvedEvent, but it was too complicated, as Add and Resolve basically mean the same operation, just in different states. Now SubjectHierarchyItemAddedEvent is invoked as usual when resolving, but it is now possible to get notified about resolving operations using SubjectHierarchyStartResolveEvent and SubjectHierarchyEndResolveEvent. This also allows processing after scene import without using a timer. [Less]

BUG: Removed memory leaks using GetNodesByClass from Python GetNodesByClass creates a new collection that the caller has to take ownership of (the caller will have to delete). Python automatically adds a reference, so we have to call UnRegister to remove the extra reference.

BUG: #3776 warning dialog gave useless/misleading information The fuzzy compare of image geometry looks at the difference between two values, but the printing of the warning set the precision based on the whole number including the digits left of ... [More] the decimal point. The result was a message that showed identical numbers and reported them as different (understandably confusing). https://www.na-mic.org/Bug/view.php?id=3776 From: Steve Pieper [Less]

ENH: Updated EMSegment to use external iterators for shared collections

BUG: Removed all iteratorless traverse of shared collections Collections have convenience functions for traversing it without the need for creating an iterator, using InitTraversal() and GetNextItemAsObject(). These functions use an internal ... [More] iterator stored in the collection. Problem: When a collection is traversed using the internal iterator by multiple functions at the same time, the behavior will be incorrect. For collections that can be accessed by multiple objects, it is almost impossible to make sure that only one function will use the internal iterator at a time. Therefore, shared collections must be traversed using external iterators. For example, this error caused a bug in View Controllers module: it only showed the first slice view controller (while there were three). The problem was that View Controllers module iterated through the nodes using the internal iterator and internally a method was called that asked for a list of nodes by classname, which used the same internal iterator. Solution: - Replaced all instances of shared collection traversal with internal iterator. - Made vtkMRMLScene's InitTraversal, GetNextNode, and GetNextNodeByClass methods deprecated (they are still functional, but log a warning when they are called). - Added vtkMRMLScene::GetFirstNodeByClass convenience function and modified functions that used InitTraversal/GetNextNodeByClass or GetNthNodeByClass(0, ...) to use this function. [Less]

BUG: Fixed go to home module shortcut The shortcut has to be added to a menu to make the shortcut action trigger signal connected to qSlicerAppMainWindow.