Slicer4

BUG: remove storable added after scene view message Testing showed that this was confusing, remove the observation on node added events from the capture toolbar as well as the pop up message. Leaves the popup timeout flag for future messages. TODO: move the test to on scene view about to be restored. Issue #3956

STYLE: add blank lines to warning message Make the message more readable by adding white space. Issue #3956

BUG: only time out extra storable message during testing The pop up window that gives the user feedback about how not to lose new storable data after creating a scene view was timing out before some testers could finish reading and understanding the ... [More] information. Added a boolean property to the capture tool bar, popupsTimeOut, that the main window can set to true when the enable testing attribute has been turned on. Verified that the test AddStorableDataAfterSceneViewTest still passes and doesn't hang. Issue #3956 [Less]

BUG: after MRB save, reset storables to modified When saving files into an MRB, the storable nodes are marked as not modified since the last save. This is a problem when new data was generated (for example via model maker) and the new files were ... [More] only saved in the now deleted MRB directory. Reset all the storable nodes to modified since reads so that saving the scene as a .mrml file and data files will succeed. Will not affect multiple MRB savings. Issue #3956 [Less]

BUG: update file list members, scene vars, update test Update the MRB save/restore test to use the slicer util delayDisplay method, as well as not counting file paths that point to the deleted bundle expansion directory. In scene view nodes make ... [More] sure to also reset the file list Restore the url and root direcotry after saving a scene to the data bundle directory so that absolute paths can be calculatediproperly Issue #3956 [Less]

BUG: Add a test that checks file paths after MRML and MRB save/load Add a test that checks the paths in the scene with saving to mrml (have to force a write of a sample data node since the saveScene call only writes out the MRML file, no storage ... [More] nodes are triggered to write) and MRB and reloading and saving to MRB. Remove skipping the master scene view as paths of storage nodes there do need to be updated. TBD: fix the paths after saving the MRB a second time (they get reset to the deleted bundle directory from the first MRB save). Issue #3956 [Less]

BUG: remove node SceneRootDir, use RootDirectory on MRML scene The node ivar scene root directory wasn't staying updated when the root directory was changing on the scene. Updated the code to refer to the scene for the root directory. One important ... [More] change is that in the XML parser, the scene has to be set on a storage node before reading/writing it so that the absolute path can be determined. Also set the scene root dir more consistently Updated the fiber bundle node test to use the testing macros since it was reproducing code. Issue #3956 [Less]

BUG: redo observations for volume loading with mini scene Found during stress testing MRBs with file paths, the final correct set of nodes used to load the volume need the storage and display node observations reset after moving from the mini scene ... [More] to the main scene. The SampleData module wasn't finding the extra storage node to remove it. Issue #3956 [Less]

BUG: fix moving volume nodes from test to main scene In testing the Reporting extension, a bug was found where error messages were being printed and the volume node had it's IJK to RAS matrix reset to identity. Removing the nodes from the test scene ... [More] before adding them to the main scene seems to have fixed this, all relevant tests are passing now. This change removes the following error messages: GetNodeByID: Node is in the scene, but its ID is missing from the NodeIDs cache: vtkMRMLScalarVolumeNode3 ditto for vtkMRMLScalarVolumeDisplayNode2 and vtkMRMLVolumeArchetypeStorageNode2 and fixes the test py_ReportingRoundTripTest Issue #3956 [Less]

ENH: stress test saving and restoring MRBs, util methods added Add a test to save and restore MRBs in a loop, fixing the bug note in the save restore test as well. Clean up the testing of saving and loading MRBs by exposing the core io manager ... [More] loadScene method to Python, and adding a saveScene one. This will simplify testing since it uses detects that it needs to use the scene writer which will use the application logic save to MRB bundle directory + zip calls, so from python you won't need to make the two calls with attendant managing of temporary directories. Added a note to the application logic header file pointing to saveScene for general use. Issue #3956 [Less]