D

DOSBox-x

Settings | Report Duplicate

2

I Use This!

Activity Not Available

Commits : Listings

Analyzed about 1 year ago. based on code collected about 1 year ago.

Commit Message	Contributor	Files Modified	Lines Added	Lines Removed	Code Location	Date
Jan 16, 2023 — Jan 16, 2024 Showing page 608 of 619 Search / Filter on:
whoops. SetEnv() checking needs room for two NULs not one.	Jonathan Campbell	More...				almost 11 years ago
Program::SetEnv() fix: before removing the variable, make sure there is room to insert the new value.	Jonathan Campbell	More...				almost 11 years ago
Found stack buffer overrun issue with Debug GUI LOG() function where, if the error message is long enough, it will overwrite the stack with part of the message and crash.	Jonathan Campbell	More...				almost 11 years ago
add #ifdef for non-dynamic core case	Jonathan Campbell	More...				almost 11 years ago
DOS shell: assign environment block from middle of DOS_FIRST_SHELL to DOS_FIRST_SHELL_END instead of assuming DOS_FIRST_SHELL to DOS_MEM_START. Wrote new Program::SetEnv() implementation that's less messy and respects the boundaries of the segment allocated to the environment block.	Jonathan Campbell	More...				almost 11 years ago
Define DOS_FIRST_SHELL_END variable to mark the end of the shell's workspace. The reason this variable is needed is because DOSBox-X's dynamic allocation mode permits additional allocation to happen before determining the value of DOS_MEM_START. And the reason that is important is because the DOS shell builtin assumed that it could use the area from DOS_FIRST_SHELL+19 to DOS_MEM_START as it's environment block, when it turns out the dynamic allocation method would have already assigned the extra space to certain DOS kernel structures. Oops!	Jonathan Campbell	More...				almost 11 years ago
cosmetic change	Jonathan Campbell	More...				almost 11 years ago
DOS shell: rewrite %variable% substitution to better emulate Win95 COMMAND.COM including how '%%' becomes '%' as well as check during the process for string overflow conditions. Prior to this fix, the DOSBox expansion code did not expand '%%' => '%' and if the string was long enough, could overflow the temp[] array on the stack. Fixed command input history buffer code to store the command PRIOR to expansion, instead of after, the way Win95 COMMAND.COM and DOSKEY would do it.	Jonathan Campbell	More...				almost 11 years ago
Internal DOS command "SET" code fixed. Removed variable substitution code. The COMMAND interpreter built into DOSBox already does the variable substitution, the parsing in CMD_SET was redundant and likely not used anyway. Additionally, the CMD_SET expansion code that was removed had a buffer overrun bug where a large environment variable could overflow the 4096-byte buffer on the stack and cause problems.	Jonathan Campbell	More...				almost 11 years ago
add to build script commentary about -g3 and -O0 flags and dynamic core	Jonathan Campbell	More...				almost 11 years ago
Final comments on what was found during Valgrind hunting.	Jonathan Campbell	More...				almost 11 years ago
Valgrind hunting: call GUI toolkit to free all fonts in it's registry on shutdown. one less memory leak reported by Valgrind.	Jonathan Campbell	More...				almost 11 years ago
Valgrind hunting: free bindlist on shutdown in mapper, remove another source of memory leaks.	Jonathan Campbell	More...				almost 11 years ago
more fiddling. there's this persistent memory leak from a std::string in the Section_line object I'm trying to get rid of.	Jonathan Campbell	More...				almost 11 years ago
more	Jonathan Campbell	More...				almost 11 years ago
hm, make destructors virtual	Jonathan Campbell	More...				almost 11 years ago
Valgrind hunting: Free ISAPNP objects on shutdown	Jonathan Campbell	More...				almost 11 years ago
more	Jonathan Campbell	More...				almost 11 years ago
hm... minor revision	Jonathan Campbell	More...				almost 11 years ago
Cleanup: make sure to clear properties list on destruct. Fix bug in config file parsing where unknown sections are treated as if continuing the previous section, which is silly.	Jonathan Campbell	More...				almost 11 years ago
add build script for maxiumum debugging	Jonathan Campbell	More...				almost 11 years ago
Valgrind hunting: CD-ROM emulation allocates a mixer channel object. Now to avert memory leaks, it frees the object. One less memory leak reported.	Jonathan Campbell	More...				almost 11 years ago
Valgrind hunting: rewrite PROGRAMS code to better track their resources, including the tiny amount of memory used to generate the executable "stub". this eliminates the many tiny memory leaks reported by Valgrind here.	Jonathan Campbell	More...				almost 11 years ago
Valgrind hunting: add shutdown function for virtual filesystem code, to free the linked list it allocates when emulating a virtual drive (such as the default drive Z:) on shutdown. This eliminates a whole bunch of memory leak messages from Valgrind.	Jonathan Campbell	More...				almost 11 years ago
Valgrind hunting: cleanup sdl_mapper to release allocated bindings, events, etc. on shutdown. Changed destructors to virtual to ensure derived classes clean themselves and the base class up properly. This eliminates Valgrind complains about memory leaks in that part of the code. Conversely, I see plenty of code using "new" to allocate an object not to assign a pointer from it but on the assumption the constructer adds itself to a list. I don't approve of that kind of C++ style and I will clean that up later.	Jonathan Campbell	More...				almost 11 years ago
Valgrind hunting: add shutdown procedure for dynamic core, to free X86 register "generators" (or whatever they are) and reduce the number of things not freed on shutdown.	Jonathan Campbell	More...				almost 11 years ago
Valgrind hunting: adjust vga_memory.cpp to memset from the base allocation not the adjusted (aligned pointer). This resolves a complaint from Valgrind that the memset() is writing beyond the end of the char[] array.	Jonathan Campbell	More...				almost 11 years ago
Valgrind hunting: CSerial destructor made virtual so classes derived from it still clean up resources properly on destruction. Added code to delete device object as well as remove from DOS kernel. added code to delete the FIFO objects properly from the destructor. Serial port emulation no longer leaks memory.	Jonathan Campbell	More...				almost 11 years ago
Valgrind hunting: PIC tick handler cleanup, deallocate tick handler linked list at shutdown to resolve minor memory leak. Keyboard code updated to remove tick handler on shutdown.	Jonathan Campbell	More...				almost 11 years ago
Valgrind hunting: resolve memory leaks with callback string allocation, and make sure the callback array is initialized properly.	Jonathan Campbell	More...				almost 11 years ago

←
1
2
…
604
605
606
607
608
609
610
611
612
…
618
619
→