Open Hub
Open Hub

 Settings |  Report Duplicate

1
I Use This!
Inactive

Commits : Listings

Analyzed 15 days ago. based on code collected 15 days ago.
Jan 29, 2024 — Jan 29, 2025
Commit Message Contributor Files Modified Lines Added Lines Removed Code Location Date
Fix a couple of code paths on which, if fxp_readdir returned an error, we would return without first closing the directory handle we had used as an argument.
Simon Tatham
More... over 11 years ago
Fix a couple of code paths on which, if fxp_readdir returned an error, we would return without first closing the directory handle we had used as an argument.
simon
More... over 11 years ago
It's not actually legal by the C standard to call qsort with a null array pointer, _even_ if you're asking it to sort zero elements so that in principle it should never dereference that pointer. Fix the four instances in PSCP/PSFTP where this was previously occurring.
simon
More... over 11 years ago
It's not actually legal by the C standard to call qsort with a null array pointer, _even_ if you're asking it to sort zero elements so that in principle it should never dereference that pointer. Fix the four instances in PSCP/PSFTP where this was previously occurring.
Simon Tatham
More... over 11 years ago
Fixes for the tree234 unit test: break its dependencies on half of the rest of PuTTY, and fix a couple of format string type mismatches pointed out by gcc.
Simon Tatham
More... over 11 years ago
Fixes for the tree234 unit test: break its dependencies on half of the rest of PuTTY, and fix a couple of format string type mismatches pointed out by gcc.
simon
More... over 11 years ago
Add missing checks in update_for_intended_size() in the font selector code, which would have coped badly if ever asked to select the first font in the list at a size smaller than it supported. Luckily the first font tended to be one of the X numeric aliases (e.g. 10x20) which was stored with size zero, so this probably didn't actually come up for anyone, but better safe than sorry.
simon
More... over 11 years ago
Add missing checks in update_for_intended_size() in the font selector code, which would have coped badly if ever asked to select the first font in the list at a size smaller than it supported. Luckily the first font tended to be one of the X numeric aliases (e.g. 10x20) which was stored with size zero, so this probably didn't actually come up for anyone, but better safe than sorry.
Simon Tatham
More... over 11 years ago
Fix a pty-freeing error which caused a segfault if you attempted to use Restart Session in a post-not-close-on-exit pterm.
Simon Tatham
More... over 11 years ago
Fix a pty-freeing error which caused a segfault if you attempted to use Restart Session in a post-not-close-on-exit pterm.
simon
More... over 11 years ago
Add some missing null checks for inst->ldisc, which were causing segfaults if a PuTTY or pterm did not close on exit and then you either typed something via input_method_commit_event or changed the line editing or echo settings.
Simon Tatham
More... over 11 years ago
Add some missing null checks for inst->ldisc, which were causing segfaults if a PuTTY or pterm did not close on exit and then you either typed something via input_method_commit_event or changed the line editing or echo settings.
simon
More... over 11 years ago
Remove another pointless null check, this time of inst->back in the function which has just dereferenced it to get the exit code.
simon
More... over 11 years ago
Remove another pointless null check, this time of inst->back in the function which has just dereferenced it to get the exit code.
Simon Tatham
More... over 11 years ago
Remove redundant null checks for arguments to sftp_{get,put}_file which are (a) never NULL anyway, and (b) have already been dereferenced by the time we make those checks so it would be too late if they were.
Simon Tatham
More... over 11 years ago
Remove redundant null checks for arguments to sftp_{get,put}_file which are (a) never NULL anyway, and (b) have already been dereferenced by the time we make those checks so it would be too late if they were.
simon
More... over 11 years ago
Fix a mishandling of error returns from makekey() in the SSH-1 private key loader.
Simon Tatham
More... over 11 years ago
Fix a mishandling of error returns from makekey() in the SSH-1 private key loader.
simon
More... over 11 years ago
Add another missing bounds check in the SSH-1 private key loader.
Simon Tatham
More... over 11 years ago
Add another missing bounds check in the SSH-1 private key loader.
simon
More... over 11 years ago
Get rid of the fixed-size 'hostname' buffer in every port-forwarded connection, and replace it with sensible dynamically allocated storage. While I'm at it, get rid of the disgusting dual use between storing an actual hostname and storing an incoming SOCKS request; we now have a separate pointer variable for each.
Simon Tatham
More... over 11 years ago
Get rid of the fixed-size 'hostname' buffer in every port-forwarded connection, and replace it with sensible dynamically allocated storage. While I'm at it, get rid of the disgusting dual use between storing an actual hostname and storing an incoming SOCKS request; we now have a separate pointer variable for each.
simon
More... over 11 years ago
Silence incorrect clang -Wconditional-uninitialized
Chris West (Faux)
More... over 11 years ago
asserts for clang --analyze
Chris West (Faux)
More... over 11 years ago
Add an assortment of extra safety checks.
Simon Tatham
More... over 11 years ago
Add an assortment of extra safety checks.
simon
More... over 11 years ago
Move the SSH-1 servkey and hostkey variables into the coroutine state, since there is a theoretical code path (via the crReturn loop after asking an interactive question about a host key or crypto algorithm) on which we can leave and return to do_ssh1_login between allocating and freeing those keys.
Simon Tatham
More... over 11 years ago
Move the SSH-1 servkey and hostkey variables into the coroutine state, since there is a theoretical code path (via the crReturn loop after asking an interactive question about a host key or crypto algorithm) on which we can leave and return to do_ssh1_login between allocating and freeing those keys.
simon
More... over 11 years ago
Clean up handling of the return value from sftp_find_request. In many places we simply enforce by assertion that it will match the request we sent out a moment ago: in fact it can also return NULL, so it makes more sense to report a proper error message if it doesn't return the expected value, and while we're at it, have that error message whatever message was helpfully left in fxp_error() by sftp_find_request when it failed.
simon
More... over 11 years ago
Clean up handling of the return value from sftp_find_request. In many places we simply enforce by assertion that it will match the request we sent out a moment ago: in fact it can also return NULL, so it makes more sense to report a proper error message if it doesn't return the expected value, and while we're at it, have that error message whatever message was helpfully left in fxp_error() by sftp_find_request when it failed.
Simon Tatham
More... over 11 years ago