Open Hub
Open Hub

 Settings |  Report Duplicate

1
I Use This!
Inactive

Commits : Listings

Analyzed 11 days ago. based on code collected 12 days ago.
Jan 29, 2024 — Jan 29, 2025
Commit Message Contributor Files Modified Lines Added Lines Removed Code Location Date
gh-57: plink/pscp/psftp can pickup file settings
Chris West (Faux)
More... over 11 years ago
Tray icon settings to Window/Behaviour
Chris West (Faux)
More... over 11 years ago
Move opacity to Window/Colours
Chris West (Faux)
More... over 11 years ago
Remove a redundant while-loop condition when reading RFC822-style header text from a PuTTY key file.
simon
More... over 11 years ago
Remove a redundant while-loop condition when reading RFC822-style header text from a PuTTY key file.
Simon Tatham
More... over 11 years ago
Remove a pointless assignment in setup_config_box.
Simon Tatham
More... over 11 years ago
Remove a pointless assignment in setup_config_box.
simon
More... over 11 years ago
Remove a return path from sshcom_write() which was both unreachable (it would trigger if !type==RSA and !type==DSA, but one of those must have been true to get there in the first place) and erroneous (it would return NULL without going through the cleanup code). Since the code's internal structure guarantees that path isn't reached, replace it with an assert.
Simon Tatham
More... over 11 years ago
Remove a return path from sshcom_write() which was both unreachable (it would trigger if !type==RSA and !type==DSA, but one of those must have been true to get there in the first place) and erroneous (it would return NULL without going through the cleanup code). Since the code's internal structure guarantees that path isn't reached, replace it with an assert.
simon
More... over 11 years ago
Use the new ctrl_alloc_with_free to clean up a long-standing FIXME in the session saving code, in which the contents of the edit box giving the current saved session name was stored in a horrid place with a fixed length. Now it's dangling off sessionsaver_data as it always ought to have been, and it's dynamically reallocated to the appropriate length, and there's a free function that cleans it up at the end of the dialog's lifetime.
Simon Tatham
More... over 11 years ago
Use the new ctrl_alloc_with_free to clean up a long-standing FIXME in the session saving code, in which the contents of the edit box giving the current saved session name was stored in a horrid place with a fixed length. Now it's dangling off sessionsaver_data as it always ought to have been, and it's dynamically reallocated to the appropriate length, and there's a free function that cleans it up at the end of the dialog's lifetime.
simon
More... over 11 years ago
Add an extended version of ctrl_alloc which permits you to provide a custom free function, in case you need to ctrl_alloc a structure which then has additional dynamically allocated things dangling off it.
simon
More... over 11 years ago
Add an extended version of ctrl_alloc which permits you to provide a custom free function, in case you need to ctrl_alloc a structure which then has additional dynamically allocated things dangling off it.
Simon Tatham
More... over 11 years ago
Move the calculation of the exchange hash to above the various warnings about insecure crypto components. The latter may crReturn (though not in any current implementation, I believe), which invalidates pktin, which is used by the former.
Simon Tatham
More... over 11 years ago
Move the calculation of the exchange hash to above the various warnings about insecure crypto components. The latter may crReturn (though not in any current implementation, I believe), which invalidates pktin, which is used by the former.
simon
More... over 11 years ago
Add a missing null pointer check in wc_unescape, to bring it in line with the usage comment saying you're allowed to pass NULL to find out only the return value. No caller actually does pass NULL at the moment.
Simon Tatham
More... over 11 years ago
Add a missing null pointer check in wc_unescape, to bring it in line with the usage comment saying you're allowed to pass NULL to find out only the return value. No caller actually does pass NULL at the moment.
simon
More... over 11 years ago
Fix another giant batch of resource leaks. (Mostly memory, but there's one missing fclose too.)
Simon Tatham
More... over 11 years ago
Fix another giant batch of resource leaks. (Mostly memory, but there's one missing fclose too.)
simon
More... over 11 years ago
Tighten up a lot of casts from unsigned to int which are read by one of the GET_32BIT macros and then used as length fields. Missing bounds checks against zero have been added, and also I've introduced a helper function toint() which casts from unsigned to int in such a way as to avoid C undefined behaviour, since I'm not sure I trust compilers any more to do the obviously sensible thing.
Simon Tatham
More... over 11 years ago
Tighten up a lot of casts from unsigned to int which are read by one of the GET_32BIT macros and then used as length fields. Missing bounds checks against zero have been added, and also I've introduced a helper function toint() which casts from unsigned to int in such a way as to avoid C undefined behaviour, since I'm not sure I trust compilers any more to do the obviously sensible thing.
simon
More... over 11 years ago
Fix an always-false if statement which was causing the window border not to be redrawn when the user reconfigured the background colour.
Simon Tatham
More... over 11 years ago
Fix an always-false if statement which was causing the window border not to be redrawn when the user reconfigured the background colour.
simon
More... over 11 years ago
-Wunreachable-code
Chris West (Faux)
More... over 11 years ago
Add an assortment of missing frees, and one missing file close. Mostly on error paths, although the one in PSFTP's wildcard_iterate will come up in normal usage.
Simon Tatham
More... over 11 years ago
Add an assortment of missing frees, and one missing file close. Mostly on error paths, although the one in PSFTP's wildcard_iterate will come up in normal usage.
simon
More... over 11 years ago
xfer_{up,down}load_gotpkt free their input sftp_packet as a side effect of handling it, but they do not free it if it isn't a packet they recognise as part of their upload/download. Invent a return value that specifically signals this, and consistently free pktin at every call site if that return value comes back. Also, ensure that that return value also always comes with something meaningful in fxp_error.
Simon Tatham
More... over 11 years ago
xfer_{up,down}load_gotpkt free their input sftp_packet as a side effect of handling it, but they do not free it if it isn't a packet they recognise as part of their upload/download. Invent a return value that specifically signals this, and consistently free pktin at every call site if that return value comes back. Also, ensure that that return value also always comes with something meaningful in fxp_error.
simon
More... over 11 years ago
Fix a collection of calls to tell_user so that they don't add their own newline before the one tell_user puts on the end anyway. Also, while I'm here, make up my mind about whether to prefix messages with "scp:" or "pscp:" - I choose the latter.
simon
More... over 11 years ago
Fix a collection of calls to tell_user so that they don't add their own newline before the one tell_user puts on the end anyway. Also, while I'm here, make up my mind about whether to prefix messages with "scp:" or "pscp:" - I choose the latter.
Simon Tatham
More... over 11 years ago