Forums : The Ohcount Project
Dear Open Hub Users,
We’re excited to announce that we will be moving the Open Hub Forum to
https://community.blackduck.com/s/black-duck-open-hub.
Beginning immediately, users can head over,
register,
get technical help and discuss issue pertinent to the Open Hub. Registered users can also subscribe to Open Hub announcements here.
On May 1, 2020, we will be freezing https://www.openhub.net/forums and users will not be able to create new discussions. If you have any questions and concerns, please email us at
info@openhub.net
How to submit patches?
Hello,
What's the preferred method of submitting patches to Ohcount? Last year it was said to be Sourceforge Trac, but I got no response for even such a simple patch as http://sourceforge.net/apps/trac/ohcount/ticket/63
Piotr,
As far as I know, ohcount is being publicly hosted at https://github.com/blackducksw/ohcount
Contact Robin Luckey at robinluckey@gmail.com with suggestions and, I presume, for commit access to the repo. Mention ticket63 to him to get his input...
Thanks!
Piotr,
P.S. I'm pretty sure the SourceForge project is no longer being developed.
Hi Piotr,
Sorry for the late response. The SourceForge project is completely abandoned, and the email address above is not my work email. Those are probably not the best way to reach me about Ohloh-related topics -- but you've found me. :-)
I admit the Ohcount code hosting situation is not clear at all. The SourceForge project page is a remnant of the brief period when SourceForge was the corporate owner of Ohloh. The SourceForge project should probably simply be completely deleted, as I am not an admin for that project and I do not believe anyone else is maintaining it.
The official
version of Ohcount is the one that Steve linked to at Github. The best way to submit a patch is to send me a pull request on Github.
However, I did find your patch on SourceForge, so you don't need to send me a pull request for this one.
I have a question about this patch. I'm having a bit of trouble understanding the disambiguate_asx() function. If I'm reading this correctly, it looks for the first non-whitespace character in a file, and if it's a '<', then we abort (and somehow this means XML?). Anything else, and we assume assembly. Do I have this correct? I think this is a bit confusing.
We don't deploy updates to Ohcount very often -- usually only once every couple of months -- but several Ohcount patches are starting to queue up, so we may do an update soon. I'd be very happy to have you contribute fixes to Ohcount, and I'm sorry it took so long to get in touch.
Robin
Hello,
Regarding disambiguate_asx, you're right. What's confusing there?
Piotr
Why does the code return NULL (with a comment that this means XML) rather than just returning XML as a result explicitly?
My intention was to detect assembly language. I don't know how XML detection works in Ohcount. Feel free to correct that.
OK, I understand at last.... :-)
Without this patch, Ohcount doesn't recognize *.asx files at all. It doesn't recognize them as XML.
With your patch, Ohcount correctly recognizes *.asx assembly code, but continues to not recognize other *.asx files. Thus, returning NULL.
All cool. I've merged your patch into our master. A mere 13 months after you've written it, this code should be live on our website in about a week.
If you have a list of projects you'd like to see recounted, let me know which ones and I'll schedule recounts once the code goes live.
Thanks,
Robin
Great! Please recount asap, lepix and atari800.
My github pull request is about to get three months old. There are other pull requests waiting as well: http://github.com/blackducksw/ohcount/pulls
@ssnow-blackduck @robin
If ohcount is officially hosted on github, please edit this page:
https://github.com/blackducksw/ohcount/wiki
Matthis,
ohcount is officially hosted on github as you show it in the above post. I don't have permissions there. See: https://github.com/blackducksw?tab=members for those who could answer additional questions.
Thanks!