Open Hub
Open Hub

 Settings |  Report Duplicate

1
I Use This!
Very Low Activity

Commits : Listings

Analyzed 14 days ago. based on code collected 15 days ago.
Jan 29, 2024 — Jan 29, 2025
Commit Message Contributor Files Modified Lines Added Lines Removed Code Location Date
Clearly headed toward results with iMinverse.cc stuff. See examples/trypetsc/poisson.c, which does the job needed for getting a regularized version of the tau_c from the basal shear stress, the sliding velocity, and a pseudo-plastic till model. Note iMinverse.cc got big so I split it.
bueler
as Ed Bueler
More... about 16 years ago
Incremental fixes to iMinverse.cc.
bueler
as Ed Bueler
More... about 16 years ago
* Changes to iMinverse.cc which put it on a good path. Now fofv is not read but computed by principled way compatible with -super model. * New method thicknessTooLarge() added, re task #4218. Almost redundant check should stay in ageStep().
bueler
as Ed Bueler
More... about 16 years ago
Incomplete work on "inverse methods" and on calving front stress boundary condition. Both incomplete.
bueler
as Ed Bueler
More... about 16 years ago
* Modified IceModel::bootstrapFromFile() and NCTool::regrid_global_var() to allow absent 't' dimension (and variable) in the bootstrapping file. Also, 'z' and 'zb' dimensions are completely ignored at the bootstrapping stage now. See task #5802. * Added the code reading valid_range, valid_min, valid_max, _FillValue and missing_value attributes and warning the user if a field in the bootstrapping file has values outside the valid range. * Code clean-up in nc_util.cc, iMbootstrap.cc and LocalInterpCtx.cc * LocalIntertpCtx(grid_info, double *, double *, IceGrid) should be called as LocalInterpCtx(grid_info, NULL, NULL, IceGrid) for 2D-only regridding. The following code from iceROSSModel.cc is an example. +verbatim+ grid_info g; ierr = nc.get_grid_info_2d(g); CHKERRQ(ierr); ierr = nc.close(); CHKERRQ(ierr);
Constantine Khroulev
More... about 16 years ago
* Sweep through iMinverse.cc methods. No intended change in semantics other than addition of ability to write out inverse model fields (basal velocity and basal shear stress). This code is ready for testing on Joughin surface velocities using essentially (or exactly) the IceGRNModel derived class. Run would look like pgrn -bif green.nc -Mx .. -My .. -Mz .. -quadZ -Lz 4000 -OTHER OPTIONS \ -y LONGISH -o foo.nc pgrn -if foo.nc -surf_vel_to_tfa green.nc -y 10 -o bar.nc assuming green.nc contained basic bootstrap fields (thk, topg, acab) and that green.nc *also* contains surface velocity in variables us,vs.
bueler
as Ed Bueler
More... about 16 years ago
Initial creation of class IceCalvBCModel, derived from IceExactSSAModel. Already has finite difference scheme which computes outward normal to calving front.
bueler
as Ed Bueler
More... about 16 years ago
Small change to semantics of FLOATING_OCEAN0: if -ocean_kill is set when -bif is done, will use OCEAN0. Otherwise -bif sets ice-free ocean to FLOATING. Note -if runs never set OCEAN0, but use it if -ocean_kill is set. Also: cleaned up standard out from iceModelVec::regrid_from_netcdf(); changes to EISMINT-Greenland stdout text to match.
bueler
as Ed Bueler
More... about 16 years ago
Moved LocalInterpCtx to src/base/LocalInterpCtx.[cc|hh].
Constantine Khroulev
More... about 16 years ago
* Fixed the EISMINT-Ross example. (I broke it in r426.) * Added IceModelVec::checkAllocated() calls to various mathods of IceModelVec.
Constantine Khroulev
More... about 16 years ago
Updated the User's Manual.
Constantine Khroulev
More... about 16 years ago
Fixed test M. Now a credible way to test coming calving front implementation. Other cosmetic changes. EISMINT-Ross example seems to be broken?
bueler
as Ed Bueler
More... about 16 years ago
* All the input/output command-line options expect a full file name (no '.nc' appending now). Specifying an output file name without the '.nc' suffix produces a warning. * Replaced all the SETERRQ(...) macros corresponding to runtime errors with {PetscPrintf(...); PetscEnd();}. All the runtime errors (such as invalid command-line arguments, etc) should produce short messages without a trace-back now. See task #5884. * Got rid of dumpToFile_diagnostic_netCDF(), used C++ default argument values to simplify initFromOptions() and writeFiles(). * Replaced 'new' with 'New' in exactTestM.c to avoid the C++ keyword name clash and 'old' with 'Old' -- for consistency. ;-)
Constantine Khroulev
More... about 16 years ago
More work on test M: matching flux at grounding line.
bueler
as Ed Bueler
More... about 16 years ago
Update to verifynow.py to run test M. Everything works fine of what I implemented in r422; prev commit message wrong. Still need to check on test M setting of velocity in grounded part.
bueler
as Ed Bueler
More... about 16 years ago
Initial implementation of test M. Something is wrong with r422 for these, but under r421 'pismv -test M -eo -Mx 201 -My 201 -Mz 11' gave high resolution version of exact solution. Will fix tomorrow.
bueler
as Ed Bueler
More... about 16 years ago
Looked at CF standard name table and modified PISM to match. Search for 'PROPOSED standard_name' to see that.
bueler
as Ed Bueler
More... about 16 years ago
* Updated src/base/iMinverse.cc and moved it to its original place. * Implemented the snapshot-saving feature, see task #6039. Now it's possible to save model state snapshots with -save_to snapshots.nc -save_at 1e3:1e3:1e4 (every 1000 years from 1000 to 10000) or -save_at 100,400,1000,5000 to save at these times. It does not affect the time-stepping mechanism, so snapshots are saved on the first time-step after the time requested. See the manual for more details. Note that saving a subset of variables in a snapshot is not supported at this point. * Documented -save_to, -save_at, -dontreadSSAvels and -a options. * Changed the default behavior when the file specified by the -o option already exists: now we print a warning, move it to filename~ (with the tilde added). It is also possible to append to the output file by giving the -a option. Updated test/verifynow.py to match this behavior. * A little bit of code clean-up in iMIO.cc * Renamed varname to short_name in IceModelVec. Also, added some more documenting comments.
Constantine Khroulev
More... about 16 years ago
Improvements to ice shelf base thermo boundary condition in preparation for use of new PISMClimateCoupler. Note vTnew3 etc. must be 'protected', not 'private', for derived class temperatureStep() to work. Should *any* IceModel members be private?
bueler
as Ed Bueler
More... about 16 years ago
More work on test M. Note build dir is a pain re creation of executables from simple?.c.
bueler
as Ed Bueler
More... about 16 years ago
More test M preliminary work.
bueler
as Ed Bueler
More... about 16 years ago
Preliminary work on test M, an 'exact' solution is a uniform thickness annular ice shelf with prescribed velocity accross grounding line (Dirichlet) and a calving front. Requires ODE solve like test L, thus not completely exact. src/verif/exactM.py is only meaningful so far. Also deleted unmaintained aix and xd1 config clutter.
bueler
as Ed Bueler
More... about 16 years ago
Modified src/base/iMbootstrap.cc to fix the bug #12645. (We need to read all the variables *before* calling setMaskSurfaceElevation_bootstrap().) Please check if it works now and leave a comment or close the bug.
Constantine Khroulev
More... about 16 years ago
Added comments to temperatureStep() to indicate where PISMClimateCoupler will be called. Changed ice shelf base temperature boundary condition to 273.15K for now; PISMClimateCoupler will fix that. Sought the source of bug #12599; not sure if bug is still present; needs PIK help to reproduce.
bueler
as Ed Bueler
More... about 16 years ago
Added ref to doc/ice_bib.bib. Trivial comment changes in src/verif.
bueler
as Ed Bueler
More... about 16 years ago
* Finished implementing the IceModelVec abstraction. See task #5762. (The list of members of IceModelVec can be changed if we need more VecXXX functionality.) * Updated and extended NCTool to search for variables using standard_name. See task #5756 and task #5802. Also, there is a change in the way PISM writes its state to a file: instead of overwriting the output file we try to append along the t dimension and overwrite if it is not possible. (Note that we should append instead of overwriting the history string of the output file.) * Removed src/netcdf (we don't need that code any more). Moved src/netcdf/pism_state.cdl to doc/. * Moved src/base/iMinverse.cc to base/old. It will come back next time I commit. * Reorganized bootstrapFromFile_netCDF() to use IceModelVec::regrid(). Moved bootstrapping variable range reporting to IceModelVec::regrid(). * Major changes to iMIO.cc: dumpToFile_netCDF() and dumpToFile_diagnostic_netCDF() use IceModelVec::write() and initFromFile_netCDF() uses IceModelVec::read() * Fixed a DAVecGetArray/DAVecRestoreArray pairing issue someplace and included a bit of code to check this pairing (only compiled with CFLAGS+=-DPISM_DEBUG). * Modified test/verifynow.py to remove verify.nc before running PISM. (This relates to the new output-appending behavior. On the other hand, this should not matter; feel free to change it back.)
Constantine Khroulev
More... about 16 years ago
Default is now changed back to Mahaffy scheme for surface gradient. The eta=H^8/3 transformation is available with -eta; -no_eta is no longer an option. verifynow.py changed accordingly. vHexactLCreated flag handled correctly in iceCompModel.cc.
bueler
as Ed Bueler
More... about 16 years ago
Fixed copy-and-paste error associated to communicating vHmelt, caused by Bueler in r407.
bueler
as Ed Bueler
More... about 16 years ago
Documentation maintenance.
bueler
as Ed Bueler
More... about 16 years ago
Added a couple of references and modified some comments.
bueler
as Ed Bueler
More... about 16 years ago