1
I Use This!
Very Low Activity

Commits : Listings

Analyzed 19 days ago. based on code collected 20 days ago.
Jan 29, 2024 — Jan 29, 2025
Commit Message Contributor Files Modified Lines Added Lines Removed Code Location Date
A couple of references added to bibliography.
bueler
as Ed Bueler
More... over 15 years ago
* Temperate case for ice/bedrock interface segment fixed, I think. * Documentation on the computation done by enthSystemCtx::solveThisColumn() is finalized. (Andy: you can print out the BOMBPROOF doc page and check it against the solveThisColumn() code. Nontrivial.) * Trivial rearranging and doc cleanup in EnthalpyConverter. * penth takes -cold option, which should then do the same as pismr except produce all the output fields usually produced by penth (and IceEnthalpyModel). So 'penth -cts' and 'penth -cts -cold' can be compared in most scripts. * Most debug clutter cleared out of IceEnthalpyModel etc.
bueler
as Ed Bueler
More... over 15 years ago
Squashed commit of the following: More... over 15 years ago
Got it: testK succeeds in IceEnthalpyModel. Docs still need some special cases.
bueler
as Ed Bueler
More... over 15 years ago
Yet more incomplete work. But really close.
bueler
as Ed Bueler
More... over 15 years ago
Ongoing, incomplete work on documenting-before-coding the enthalpy scheme.
bueler
as Ed Bueler
More... over 15 years ago
* Cleaned up signatures in trivial ways to quash warnings in doxygen-erating. * Simplified enthalpy normalization in bedrock; not tested or expected to run well, but we know the path of righteousness to follow. * More work on BOMBPROOF-for-enthalpy docs. My plan is to fully document the ice/bedrock interface change before actually implementing it in enthColumnSystem.cc.
bueler
as Ed Bueler
More... over 15 years ago
Got it. That is, I know how to proceed on the ice-bedrock interface, with respect to an enthalpy formulation there. Created new BOMBPROOF page for notes. Will write notes first and modify enthColumnSystem.cc and enthalpyConverter.cc when I like the notes.
bueler
as Ed Bueler
More... over 15 years ago
Added tools to columnSystemCtx to help diagnose issues in IceEnthalpyModel. Use options '-view_sys -id N -jd M' to see system at map-plane (i,j)=(N,M).
bueler
as Ed Bueler
More... over 15 years ago
Squashed commit of the following: More... over 15 years ago
Squashed commit of the following: More... over 15 years ago
* r731 didn't compile even for me. Sorry for the stupidity. Different method for quashing 'unused parameters' warnings; compiles for me at least ... * Changed LocalMassBalance init, to hand in a config without using MPI calls or an IceGrid.
bueler
as Ed Bueler
More... over 15 years ago
Quash pedantic compiler warnings. (Now I have set PISM_USE_DEBUG=1, so that I see them on my development machine. The compiler defaults on ARSC machines are pedantic/extras, you see.)
bueler
as Ed Bueler
More... over 15 years ago
Trivial change to user manual to get figure numbers right.
bueler
as Ed Bueler
More... over 15 years ago
Added simpler diagnostic view methods to ColumnSystem and EnthalpyConverter, in an attempt to find error made obvious by Test K, in penth. (pismv, pismr do fine).
bueler
as Ed Bueler
More... over 15 years ago
Added #include <algorithm> to Timeseries.cc to address bug #13731. More... over 15 years ago
Completion of unfinished business in r725. Documented the NCO route to alternate config.
bueler
as Ed Bueler
More... over 15 years ago
* Added documentation and cleaned up verbose output related to using and viewing alternate configuration (-config foo.nc). * Used dynamic_cast correctly to avoid constructing multiple IceModel derivatives in pisms.cc and pismd.cc. Note pismd is deprecated anyway.
bueler
as Ed Bueler
More... over 15 years ago
* Fixed one substantive bug re ice-bedrock interface. * Nonethless still not satisfied with bedrock temp behavior. * I think we can use Test K to test IceEnthalpyModel, even fairly easily. * Some additional code hardening and comment corrections. * Parallel communication should be fine; report right away if processor- dependence for results of sample runs, lines at top of src/penth.cc.
bueler
as Ed Bueler
More... over 15 years ago
More refactoring on IceEnthalpyModel and related tools. No sign of processor-dependence bug, but there is a problem with positive thickness bedrock layer. New version does conversion from temperature to enthalpy for bedrock outside of EnthColumnSystem.
bueler
as Ed Bueler
More... over 15 years ago
* Removed src/coupler/forcing.*, because it is not used any more. * Implemented Timeseries::write() and the (new) DiagnosticTimeseries class. The latter makes it fairly easy to write time-series to NetCDF files (it does not write every time you add an entry, avoiding lot of I/O and does not store more than a given number of entries, reducing memory use). Note that this code is tested, but is not used (yet). Please see the DiagnosticTimeseries doc string or the class browser for details. More... over 15 years ago
Replaced 'static const' with 'const'. Fixes penth bug on at least one machine.
bueler
as Ed Bueler
More... over 15 years ago
Changed to new enthalpy normalization following Aschwanden-Bueler conversation 6/16. Many other clean-ups. Definitely IceEnthalpyModel has a parallel communication bug.
bueler
as Ed Bueler
More... over 15 years ago
* Completed task #6641 * Fixed bug #13413, switched over to the new Timeseries object for climate forcing and IceROSSModel, changed eiscore.py to produce time-series suitable for linear interpolation * Minor code cleanup, typos, etc More... over 15 years ago
Added ability to regrid enthalpy with 'y' flag: '-regrid_vars y'.
bueler
as Ed Bueler
More... over 15 years ago
* Trivial appearance changes to penth.cc, pccoupler.cc. * Addition of -temp_pa, which writes pressure-adjusted temperature at end of run, in deg_C. * Cleaning, finishing enthalpy method. * I still need reassurance on functions in enthalpyHelper.hh. Does temperature of a chunk of cold ice change just as you change the pressure?
bueler
as Ed Bueler
More... over 15 years ago
IceEnthalpyModel *much* betters. Runs without producing nonsense for anything. Still has many 'FIXME' in core routines. Andy: we can talk about these and finish up, I think.
bueler
as Ed Bueler
More... over 15 years ago
Finally I have written all the code for the first time for IceEnthalpyModel. Does not work right yet, of course, but compiles produces some numbers.
bueler
as Ed Bueler
More... over 15 years ago
Improvements in exposition of standard_names table. Removal of obscure comment in iMgeometry.cc; if we want to know about calving laws we should ask PIK.
bueler
as Ed Bueler
More... over 15 years ago
Small changes to IceEnthalpyModel.
bueler
as Ed Bueler
More... over 15 years ago