Open Hub
Open Hub

 Settings |  Report Duplicate

1
I Use This!
Very Low Activity

Commits : Listings

Analyzed 22 days ago. based on code collected 23 days ago.
Jan 29, 2024 — Jan 29, 2025
Commit Message Contributor Files Modified Lines Added Lines Removed Code Location Date
* Annihilated IceEnthalpyModel. Executable penth remains only so that a NON-functioning penth is built in your bin/ directory (instead of holding over the old one). Will be deleted in a few commits.
bueler
as Ed Bueler
More... almost 15 years ago
* Fixed compute_temp_pa so that diagnostic output temp_pa is in degrees celsius; this is wrong in r993.
bueler
as Ed Bueler
More... almost 15 years ago
* Moved the write of liqfrac and cts from IceEnthalpyModel to IceModel::write_model_state(). Note that temp_pa and liqfrac are written either if user asks specifically for them or if doColdIceMethods==false, while cts is written only if user asks specifically. This maintains previous semantics.
bueler
as Ed Bueler
More... almost 15 years ago
Moved six procedures which convert IceModelVec3 thermal fields from IceEnthalpyModel into IceModel and new file src/base/iMenthalpy.cc. (Conversions are among temperature, liquid fraction, and enthalpy.)
bueler
as Ed Bueler
More... almost 15 years ago
* Moved creation of IceModelVec3's "Enth3" and "Enthnew3" into IceModel. This implies a performance hit for all PISM executables, until the conversion to enthalpy-based runs are complete and we remove T3 and Tnew3. Deleted IceEnthalpyModel::createVecs().
bueler
as Ed Bueler
More... almost 15 years ago
Added an EnthalpyConverter* to IceModel, and removed local creation of it in various IceEnthalpyModel methods. Moved content of IceEnthalpyModel::init_physics() to IceModel. Changed regularization warm_base_flux_enthalpy_fraction to 0.0001 from 0.02. (This is the first of several changes which will remove IceEnthalpyModel as a separate class.)
bueler
as Ed Bueler
More... almost 15 years ago
Lots of (boring) changes related to PISM command-line option processing overhaul (task #6493).
Constantine Khroulev
More... almost 15 years ago
Re-added 100 year SIA smoothing step to searise-greenland/spinup.sh, which is needed for reasonable -no_mass performance. Also fixed filename bug (PRE4NAME) in same script. And cleaned eisgreen/try_penth.sh.
bueler
as Ed Bueler
More... almost 15 years ago
Fix of bug introduced by Bueler in commit r920. This commit was supposed to fix bug #13974, but introduced a different problem. This bug fix is highly-relevant to any evaluation of results from trunk versions 920--986 inclusive.
bueler
as Ed Bueler
More... almost 15 years ago
- usermanual updated - some work on the cheat sheet - fixed eisross example - fixed typo in some python files (was my mistake)
Andy Aschwanden
More... almost 15 years ago
- added new extra_vars to userman - added enthalpybase, enthalpysurf to extra_vars - minor modification in check_stationarity.py
Andy Aschwanden
More... almost 15 years ago
Squashed commit of the following:
Andy Aschwanden
More... almost 15 years ago
Added regularization which allows some heat flux into base when the ice is slightly warmer than pressure-melting. Also fix to allow bootstrapping runs, without false error message.
bueler
as Ed Bueler
More... almost 15 years ago
* Improved error checking in the regridding code. * Re-factored NCTool. NCTool is split in two parts: a minimal NetCDF wrapper (new "NCTool") and a class for reading/writing PETSc Vecs that needs to know about IceGrid ("PISMIO"). * Moved IceGrid defaults into pism_config.cdl. * Finished task #6978.
Constantine Khroulev
More... almost 15 years ago
Squashed commit of the following:
Andy Aschwanden
More... almost 15 years ago
* For IceEnthalpyModel, in case of downward velocity at a temperate ice base, added source terms and horizontal advection terms to "outflow boundary condition". This seems to not change the basal melt rate very much relative to r979. In the Storglaciaren runs and Greenland runs I did, anyway. (What bmelt is right? Some precise knowledge is needed to guide choices. I cannot think for now of credibly-important thermodynamics which is missing from the code.)
bueler
as Ed Bueler
More... almost 15 years ago
New material in User's Manual looks good. Here are small edits. Also a figure had not been committed; thisone is PDF from inkscape applied to the corresponding SVG.
bueler
as Ed Bueler
More... almost 15 years ago
Fixed a bug in PISMSurface that caused a crash if -surface constant and -extra_... were used at the same time.
Constantine Khroulev
More... almost 15 years ago
- added ienthalpy (volume integral of enthalpy, units Joule) to timeseries as a default output variable - modified Makefile(s) to avoid clashes with different versions of PISM and run scripts
Andy Aschwanden
More... almost 15 years ago
Updated Schoof references.
bueler
as Ed Bueler
More... almost 15 years ago
* Added configuration parameters hmelt_diffusion_distance and hmelt_diffusion_time. * Replaced max_hmelt with hmelt_max (for consistency).
Constantine Khroulev
More... almost 15 years ago
Modified error reporting when EnthalpyConverter dects ice that is fully-liquified; now it does not break but indicates with error code. IceEnthalpyModel counts volume of ice that was fully liquified in one time step.
bueler
as Ed Bueler
More... almost 15 years ago
* Added better error messages if an argument of -atmosphere, -surface or -ocean is mistyped. * Moved grid.{ice,bed}_vertical_spacing == EQUAL check from IceEnthalpyModel into IceModelVec3[Bedrock]::getValColumn(). * Some work on the User's Manual.
Constantine Khroulev
More... almost 15 years ago
In r971 the basal water layer thickness (bwat=vHmelt) was not being updated from the basal melt rate, as opposed to drainage. Fixed. Also added script to compare pismr and penth results for EISMINT-Greenland.
bueler
as Ed Bueler
More... almost 15 years ago
* Dealt with all bugs identified in r967 commit message.
bueler
as Ed Bueler
More... almost 15 years ago
* Fixed L[0] out-of-bounds array access in iceenthOnlySystemCtx::solveThisColumn(). Thanks for finding this one, Constantine.
bueler
as Ed Bueler
More... almost 15 years ago
* Preliminary work on the bed deformation model (i.e. re-factoring). * Option -help shows possible -atmosphere, -surface and -ocean choices. * Fixed pgrn (it suffered from a bug similar to #15420).
Constantine Khroulev
More... almost 15 years ago
quick hack in practical-usage.text to make userman compiling
Andy Aschwanden
More... almost 15 years ago
* enthColumnSystem.hh|cc removed
bueler
as Ed Bueler
More... almost 15 years ago
IceEnthalpyModel code now in intended condition. Only combinedSystemsCtx.cc needs implementing, following BOMBPROOF docs. (On next commit I will do that, and turn compilation of penth back on.)
bueler
as Ed Bueler
More... almost 15 years ago