FFADO

Add "Keywords" entry to desktop file. Include the "Keywords" entry in the FFADO desktop file. This benefits Debian and possibly others. Patch by Nicolas Boulenguez for Debian and provided to FFADO by Benoit Delcour via the ffado-user mailing list.

RME: fix output fader array overflow. Human readable output fader volumes are stored in the device setting's output_faders array. The RME hardware flash interface requires derived values, which are generated and stored in a separate buffer when ... [More] needed. This buffer has 32 elements. The last two elements are not fader values, but a flag to indicate that MIDI is active (element 30) and a submix number (element 31). It is suspected that these are for the convience of computer software and are not used by the RME hardware. FFADO does not make use of either element. As a result, only 30 fader values were copied between the flash buffer and the output_faders array. However, this creates a buffer overflow in the output_faders array, since this is defined to have RME_FF800_MAX_CHANNELS elements, and RME_FF800_MAX_CHANNELS is 28. The fix is to use the local "nch" variable as the upper bound on the value conversion loop rather than a fixed value of 30. Unused flash buffer elements will be unread or unwritten, which is acceptable since the relevant flash buffer and fader arrays are always zeroed before use. This issue was flagged by a QA warning in Gentoo and reported to the ffado-devel mailing list by Hector Martin, along with the suggested fix. [Less]

Python3 syntax fixes From Hector Martin via the FFADO-devel mailing list. Fix 3 syntax issues required by python 3: sloppy use of whitespace which python2 was evidently happy with, some missed print() conversions, and an unused import that no longer exists. Tested on Python 2.7, 3.4, 3.5 with Qt5, and Python 2.7 with Qt4.

Crossbar router fix Patch provided by Hector Martin via the FFADO-devel mailing list. From Hector: IIRC this was broken since at least mid last year if not earlier, in PyQt?4 too. Tested on Python 2.7, 3.4, 3.5 with Qt5.

Additional Python 3 fixes Apply additional Python 3 fixes from Hector Martin via the FFADO-devel mailing list. The exec() based approach in panelmanager.py no longer works (it is replaced with importlib). Fix what looks like a typo in ... [More] crossbarrouter.py which just happened to work in Python 2.7 (Hector understands the intent is to avoid negative values, not "negative" keys which are actually strings). Clarify float/truncating division. Tested on Python 2.7, 3.4, 3.5 with Qt5, and Python 2.7 with Qt4. [Less]

Further Python3/PyQt5 compatibility fixes, enhance "About" dialog box. This patch was prepared by Orcan Ogetbil on Fedora and tested on that distribution with PyQt?4-4.12.1 and PyQt?5-5.9.1. It is primarily concerned with additional compatibility ... [More] between Python2/3 and PyQt?4/5. It has also been tested under python 2 with pyqt 4.11.4. Further testing under different python/pyqt environments would be welcomed. An enhancement to the "About" dialog is also included which adds version strings and updates the copyright year range. The patch was submitted to the ffado-devel mailing list. [Less]

SCons: fix detection of dbus on PyQt?5 systems. The detection of the dbus python modules was qualified on the presence of pyuic4. On systems with only PyQt?5 this would obviously fail. Patch from Orcan Ogetbil via the ffado-devel mailing list. ... [More] r2724 inadvertently included a change to SConstruct to import sys. This is needed since sys.stdout is referenced in some situations (in particular, if jack is not installed in the build environment). This patch was also from Orcan Ogetbil, via the ffado-devel mailing list. [Less]

RME: ensure byte swap macros are available for all components. The byte swap macros (ByteSwap?32() in particular) are required on big-endian architectures for more than just the rme_avdevice module. Including these in the RME device header file is a reasonable way to fix this. Patch from Orcan Ogetbil via the ffado-devel mailing list.

Tag FFADO version 2.4.0.

SConstruct: bump trunk version to 2.4.9999 for the next development round.