Posted
almost 2 years
ago
by
Julian Pistorius
@latimerscope could you please use appropriate values from context.localization instead of hardcoded strings "Image" and "Snapshot"?
|
Posted
almost 2 years
ago
by
Julian Pistorius
I like how this works @latimerscope! Thank you for this. Other than the small change about localization I requested this looks good to me. @cmart please have a look when you are ready.
I think a follow-up issue should be to hide snapshots by default. Let me know what you think cmart.
|
Posted
almost 2 years
ago
by
Julian Pistorius
It's only persisted on the instance.
If we need to have it persisted outside of an instance then we would look at things like instance snapshots, OpenStack volumes, shared file systems, etc.
|
Posted
almost 2 years
ago
by
Julian Pistorius
@cmart wrote:
It looks like we are bind mounting /data to the container but the contents are lost on restart.
I can't reproduce this. The content of /data persists between restarts.
However, for this to be useful the user needs to know to save
|
Posted
almost 2 years
ago
by
Julian Pistorius
Thanks for investigating this @aszenz, and for your fix that uses Docker volumes. I've tested it and it behaves as you describe. I especially like how any changes to the home directory inside the container persists.
See my comment #832 (comment
|
Posted
almost 2 years
ago
by
Julian Pistorius
Thanks @aszenz. Do you think you can test this to confirm your hypothesis?
|
Posted
almost 2 years
ago
by
Julian Pistorius
|
Posted
almost 2 years
ago
by
Julian Pistorius
Overview
Display number of items and number of filtered items in toolbar of datalist widget
Fixes #887
How to Test
Look at various lists (Images, Instances, ...), both filtered and unfiltered.
Screenshots
|
Posted
almost 2 years
ago
by
Julian Pistorius
Thank you @jxxcarlson! It looks good. 🌈
|
Posted
almost 2 years
ago
by
James Carlson
Is there anything that I need to do? There are three unresolved threads and a button saying "Finish review."
|