Box Backup

(diff)

(diff)

(diff)

(diff)

Re-enable test_dir_fixing.

Improve debugging messages after repairing a directory. Report whether the directory still had errors after the first pass of dir.CheckAndFix?(), and also whether a file is marked as both Old and Deleted, which means that its block usage is not ... [More] accounted for anywhere. There's possibly still a bug here where an invalid directory entry that is itself a directory may not result in the parent directory being marked as isModified and written back out afterwards, which may be what's happening to Markus Grunwald (failure to correct the error with "check fix"). [Less]

Fix a bug where bbstoreaccounts check could hang or crash. It's not safe to use an iterator after the underlying collection has been modified. We need to restart iterating over the directory in that case. Otherwise we could loop forever looking for an end() that we've already passed, or start accessing unallocated memory.

Improve variable names and comments. Makes the source code more readable.

Improve error messages from BackupCommands?. When a command is sent in the wrong phase, or a command that requires write access is sent to a read-only session, log an error message with the command details (and current phase in the former case).

Refactor testbackupstorefix. Preparation work for better testing of fixing directories with entries that no longer exist on disk. Related to debugging the problems reported by Markus Grunwald.